Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with not building from sdist #91

Merged
merged 15 commits into from
Sep 22, 2024
Merged

Conversation

hajimes
Copy link
Owner

@hajimes hajimes commented Sep 22, 2024

This PR fixes the issue reported in #90 that the package could not be built from the source distribution (sdist). It also adds tests to verify building from the source distribution, ensuring this issue does not recur.

The PR also includes a few minor documentation fixes and enhancements.

@hajimes hajimes merged commit 124e267 into master Sep 22, 2024
64 checks passed
@hajimes
Copy link
Owner Author

hajimes commented Sep 23, 2024

To be clear, in mmh3 4.* this issue should not occur, as it was introduced in #79.

The commit #79 removed MANIFEST.in, because setup.py is no longer required by setuptools. On my local environment, the default setuptools configuration in pyproject.toml included *.h files during python -m build --sdist, but on other systems, this default configuration does not include them. I’m not sure why this discrepancy occurred, but in any case this PR resolves the issue by explicitly declaring *.h as additional package data."

[tool.setuptools]
include-package-data = true
# ...

[tool.setuptools.package-data]
mmh3 = ["*.h"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant